Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Separate eth providers into individual providers per exchange (backport #406) #408

Closed
wants to merge 1 commit into from
Closed

feat: Separate eth providers into individual providers per exchange (backport #406) #408

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 31, 2024

Description

closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)
This is an automatic backport of pull request #406 done by [Mergify](https://mergify.com).

@rbajollari @mergify
feat: Separate eth providers into individual providers per exchange (#…
957dd46 
…406)

(cherry picked from commit 3db3979)

# Conflicts:
#	config/supported_assets.go
#	oracle/oracle.go
#	oracle/provider/provider.go
@mergify Mergify
Copy link
Author

mergify bot commented Aug 31, 2024

Cherry-pick of 3db3979 has failed:

On branch mergify/bp/umee/pr-406
Your branch is up to date with 'origin/umee'.

You are currently cherry-picking commit 3db3979.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   oracle/provider/balancer.go
	new file:   oracle/provider/balancer_test.go
	new file:   oracle/provider/camelot.go
	new file:   oracle/provider/camelot_test.go
	new file:   oracle/provider/curve.go
	new file:   oracle/provider/curve_test.go
	new file:   oracle/provider/pancake.go
	new file:   oracle/provider/pancake_test.go
	modified:   oracle/provider/uniswap.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   config/supported_assets.go
	both modified:   oracle/oracle.go
	both modified:   oracle/provider/provider.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Aug 31, 2024
@mergify mergify bot requested a review from a team as a code owner August 31, 2024 17:03
@mergify mergify bot mentioned this pull request Aug 31, 2024
Merged
17 tasks
@mergify mergify bot deleted the mergify/bp/umee/pr-406 branch September 4, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamewozniak @rbajollari